Various test improvement, especially for testing minimal templates #639
+72
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmarek
force-pushed
the
tests-minimal
branch
from
e01beb9
to
58871e8
Compare
This allows more effective skipping tests for specific templates - without doing any setUp/tearDown.
... using another template for management dvm. That other template can be selected with QUBES_TEST_MGMT_TPL variable. For this to fully work, test updating a template instead of AppVM, as it will use updates proxy which should work with minimal template (contrary to direct network access).
This makes sense for testing if in-vm kernel works out of the box in selected templates. QubesOS/qubes-issues#5212
Plain minimial template wont work, but this allows testing if minimal + just networking packages installed. Specifically, this tests if installing qubes-core-agent-networking is enough to get networking working with minimal template.
marmarek
force-pushed
the
tests-minimal
branch
from
58871e8
to
469e147
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 69.49% 69.44% -0.06%
==========================================
Files 58 58
Lines 12465 12434 -31
==========================================
- Hits 8663 8635 -28
+ Misses 3802 3799 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024120220-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update
Failed tests7 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/119126#dependencies 3 fixed
Unstable tests
|
This was referenced Nov 30, 2024
Skip only the direct (no-proxy) update test, as minimal template doesn't have networking packages included. But do test all scenarios with proxy, just use the default template for repo-hosting VM.
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.