Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Query Interface and some doc fixes #92
added Query Interface and some doc fixes #92
Changes from 3 commits
e2022ae
5234936
66e08ee
cd5113f
f4aafee
c21d60c
bd1538d
4d34e62
f5dec90
ca1eef0
3b9d885
81e93de
b53f74e
d7c3fe6
8f909c6
428b75e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only one way to construct a tag, and in particular the tags described above are NOT constructed this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get that, isn't this the only way we create tags. Even in ProtocolZoo, we never explicity create instances of the tags described above, its always done through
tag!
which is listed below this part. Is there something I'm missing here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, did you mean doing something like,
I'll list this way too here, let me know if you meant something else
But this still won't allow to define the above tags
To create the above tags only
Tag
seems to be available andtag!
is used when we add the tag to a ref