Improvements to the CircuitZoo purification circuits (fixes #32 and #31) #37
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
===========================================
- Coverage 65.15% 21.14% -44.02%
===========================================
Files 23 23
Lines 927 960 +33
===========================================
- Hits 604 203 -401
- Misses 323 757 +434
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Krastanov
changed the title
There was a bit of confusion here. The point of entanglement distillation is to purify pairs that are not all store on the same node. I.e. Alice has two halves of two different Bell pairs. Bob has the other halves. This is very different from Alice locally having a Bell pair and Bob locally having an independent Bell pair -- there is no shared entanglement in such a case and no possiblity for quantum networking. A second issue is that the purification was reporting a failure in the docstring - this could have been a sign to investigate what the problem is.
|
@Barosandu , please check the 6 commits I pushed one by one for the changes I have made. We should discuss anything that might have been unclear at our meeting tomorrow. I also enabled the doctests: currently a lot of the new ones are failing. Could you make sure they run correctly before we merge this? |
|
forgot to mention: to run the doctests, you do not need to run the entirety of the test suite. You can just open the test_doctests.jl file in your editor and execute it in the REPL that is connected to vscode. |
… of qubits or nodes and pair of Bell pairs
|
@Barosandu , please check the changes I have made. Let me know if there are any you disagree with or would like to discuss. I will merge this so that it does not block other tasks. Could you submit a separate pull request that addresses the TODOs I have left in? |
All i have left is to check the varargs length
edit done