Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fullstack example #33

Closed
wants to merge 39 commits into from

Conversation

adrianariton
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (29d87e4) 65.15% compared to head (de76a63) 64.00%.
Report is 45 commits behind head on master.

Files Patch % Lines
src/CircuitZoo/CircuitZoo.jl 52.57% 46 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   65.15%   64.00%   -1.16%     
==========================================
  Files          23       23              
  Lines         927      975      +48     
==========================================
+ Hits          604      624      +20     
- Misses        323      351      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrianariton
Copy link
Contributor Author

adrianariton commented Aug 26, 2023

@Krastanov line 13 in Sim.jl should be changed from

retina_scale = 1

to

retina_scale = 2

if ran on a Mac with retina display that supports double pixelling (if not changed, the figure resolution will be halved).
And left as such otherwise.

@adrianariton adrianariton changed the title Adde fullstack example Adding fullstack example Aug 26, 2023
@Krastanov
Copy link
Member

Thanks, this is very helpful!

I see you have a compat bound for WGLMakie. Probably related to MakieOrg/Makie.jl#3161 ?

I will try to give a review later today

@Krastanov
Copy link
Member

There seems to be a session sharing issue (similar to the one originally reported in your CSSMakieLayout initial version). If I enable logs and open a second page http://localhost:8888/1, the logs from the simulation in the first page end up visible also on the second page. These should be separate sessions.

@adrianariton
Copy link
Contributor Author

Yep! Didn't notice that. I will fix is ASAP.

@Krastanov
Copy link
Member

No worries! It is not urgent and I will be sending more comments throughout the day anyway

@adrianariton
Copy link
Contributor Author

I think it should be working now

@adrianariton
Copy link
Contributor Author

I'll just leave my TODOs here so i remember them:

  • add limits to waittime distrib. plot, and also plot it on menufig1
  • cleanup first plot a little bit
  • add log on both interfaces
  • redo the landing page so it matches the updated version

@adrianariton
Copy link
Contributor Author

@Krastanov i added the README and Docs (you will notice that for sumtypes they are still comments, because i get an error saying they are not documentable).

@Krastanov Krastanov added the completed experiment testing an approach to do something (but different approach taken at the end) label Dec 18, 2023
@Krastanov
Copy link
Member

This was a very useful experiment, which informed our current approach, namely the use of query and tags by various protocols.

There are a few other useful developments here that we have not merged (the neat html makie layout, detailed networking diagrams, etc).

@Krastanov Krastanov closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed experiment testing an approach to do something (but different approach taken at the end)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants