-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding fullstack example #33
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 65.15% 64.00% -1.16%
==========================================
Files 23 23
Lines 927 975 +48
==========================================
+ Hits 604 624 +20
- Misses 323 351 +28 ☔ View full report in Codecov by Sentry. |
@Krastanov line 13 in Sim.jl should be changed from
to
if ran on a Mac with retina display that supports double pixelling (if not changed, the figure resolution will be halved). |
Thanks, this is very helpful! I see you have a compat bound for WGLMakie. Probably related to MakieOrg/Makie.jl#3161 ? I will try to give a review later today |
There seems to be a session sharing issue (similar to the one originally reported in your CSSMakieLayout initial version). If I enable logs and open a second page |
Yep! Didn't notice that. I will fix is ASAP. |
No worries! It is not urgent and I will be sending more comments throughout the day anyway |
I think it should be working now |
I'll just leave my TODOs here so i remember them:
|
@Krastanov i added the README and Docs (you will notice that for sumtypes they are still comments, because i get an error saying they are not documentable). |
This was a very useful experiment, which informed our current approach, namely the use of There are a few other useful developments here that we have not merged (the neat html makie layout, detailed networking diagrams, etc). |
No description provided.