Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Group Presentation for Cyclic Group Cₘₕ = Cₘ × C₂ #398

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Oct 19, 2024

This PR reproduces the Table 2 by using presentation of cyclic group instead of Direct Product of cyclic groups which was done in: #392

As $C_{mh} = C_m \times C_2 = \langle x, s \mid x^m = s^2 = xsx^{-1}s^{-1} = 1 \rangle$, there are two ways to reproduce Table 2:

  1. $C_m \times C_2$
  2. $\langle x, s \mid x^m = s^2 = xsx^{-1}s^{-1} = 1 \rangle$

This PR implements the 2) approach. This second approach was not mentioned in the caption of Table 2 but was referenced in the text of the Appendix. Both gives the same results.

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them. There will be plenty of old code that is flagged as we are slowly transitioning to enforced formatting. Please do not worry about or address older formatting issues -- keep your PR just focused on your planned contribution.

@Fe-r-oz Fe-r-oz force-pushed the cyclicpresentation branch from d3162ae to d47f59f Compare October 19, 2024 07:34
@Fe-r-oz Fe-r-oz changed the title Group Presentation for Cyclic Group Cₘₕ = Cₘ × C₂ tests: Group Presentation for Cyclic Group Cₘₕ = Cₘ × C₂ Oct 22, 2024
@Fe-r-oz Fe-r-oz force-pushed the cyclicpresentation branch from d47f59f to 275db7a Compare October 24, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant