Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement sSQRTXX, sInvSQRTXX, sSQRTYY, sInvSQRTYY #368

Merged
merged 4 commits into from
Nov 2, 2024

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Sep 24, 2024

This PR completes all the last remaining two qubit gates that were missing from https://github.com/quantumlib/Stim/blob/main/doc/gates.md.

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.

@Fe-r-oz Fe-r-oz changed the title add SQRTXX, SQRTYY, and their inverses implement sSQRTXX, sInvSQRTXX, sSQRTYY, sInvSQRTYY Sep 24, 2024
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Sep 24, 2024

The PR is ready. There will be merge conflicts after merging #336, so after that is merged, I will update this and request for review. Thank you!

This PR along with #336 completes all the two qubit symbolic gates w.r.t to stim so maybe #45 can be considered for closing now?

For stim reference

SQRTXX: https://github.com/quantumlib/Stim/blob/main/doc/gates.md#SQRT_XX
InvSQRTXX: https://github.com/quantumlib/Stim/blob/main/doc/gates.md#the-sqrt_xx_dag-gate

SQRTYY: https://github.com/quantumlib/Stim/blob/main/doc/gates.md#the-sqrt_yy-gate
InvSQRTYY: https://github.com/quantumlib/Stim/blob/main/doc/gates.md#the-sqrt_yy_dag-gate

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.48%. Comparing base (f3eb7cd) to head (4f4b2fe).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   82.42%   82.48%   +0.05%     
==========================================
  Files          70       70              
  Lines        4580     4584       +4     
==========================================
+ Hits         3775     3781       +6     
+ Misses        805      803       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Oct 25, 2024

Let's add the remaining of these as well @Krastanov, Thanks!

This PR completes the set of named two-qubits gates w.r.t to stim.

@Krastanov Krastanov merged commit c3546cd into QuantumSavory:master Nov 2, 2024
16 of 18 checks passed
@Krastanov
Copy link
Member

thank you, this is great to have

@Fe-r-oz Fe-r-oz deleted the new2ops branch November 2, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants