Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually fix the thing I said I fixed before... #38

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

lkdvos
Copy link
Member

@lkdvos lkdvos commented May 30, 2024

:(

@lkdvos lkdvos requested a review from leburgel May 30, 2024 13:45
Copy link
Collaborator

@leburgel leburgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also didn't notice, was not paying close attention. I guess it's pretty hard to add a test for this kind of edge case?

@lkdvos
Copy link
Member Author

lkdvos commented May 30, 2024

The only thing I could come up with is to start from something symmetric, and not impose the symmetry, but even then, I would guess that the PEPS will just break the symmetry anyways, which leads to a super contrived setup to test this stupid warning message... maybe its fine just like this, Gleb tested it so now at least it runs...

@leburgel
Copy link
Collaborator

I did explicitly try out the line which gets the singular value dict this time around, so it should be good to go now.

@lkdvos lkdvos merged commit 4bc4980 into master May 30, 2024
11 checks passed
@lkdvos lkdvos deleted the ld-logging2 branch May 30, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants