Fix faulty CTMRG contractions #110
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
lkdvos
previously approved these changes
Dec 21, 2024
|
Before merge, can we fix one more docstring? PEPSKit.jl/src/utility/rotations.jl Line 14 in 3158c04 I think it is actually |
|
You're right, thanks for catching that. By the way, one of the next things I'll do in the code is a major overhaul of the documentation. I will try to improve (correct) all docstrings and write up proper examples showcasing all features of the package. So if you have suggestions on the docs, let me know - I'll tag you, once I open up the PR! |
lkdvos
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR which fixes a wrong
conjand index mismatch inctmrg_contractions.jl. Thanks to @Yue-Zhengyuan and @Sander-De-Meyer for bringing this up!