Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for managing users #345

Merged

Conversation

ecksun
Copy link

@ecksun ecksun commented Jan 27, 2025

This solves issue #303

Reference: #342

I would have preferred to have different types for the different operations but I couldn't find an easy way of modeling that in BcXml (for example user_id is not included when creating a user)

It seemed to be a child of AbilitySupport, which is not the case
dissector/messages.md Outdated Show resolved Hide resolved
@ecksun ecksun changed the title Feature/users Add support for managing users Jan 27, 2025
crates/core/src/bc_protocol/users.rs Outdated Show resolved Hide resolved
crates/core/src/bc_protocol/users.rs Outdated Show resolved Hide resolved
crates/core/src/bc_protocol/users.rs Outdated Show resolved Hide resolved
src/users/mod.rs Show resolved Hide resolved
crates/core/src/bc_protocol/users.rs Outdated Show resolved Hide resolved
crates/core/src/bc_protocol/users.rs Show resolved Hide resolved
Support includes:
- Listing users
- Creating users
- Deleting users
- Changing the password of users
@ecksun
Copy link
Author

ecksun commented Jan 29, 2025

Thank you for the feedback! it made the code much better

Skip deser the pass field for camera's that try to sent it in the user list
@QuantumEntangledAndy QuantumEntangledAndy merged commit 6e05e78 into QuantumEntangledAndy:master Jan 30, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants