forked from thirtythreeforty/neolink
-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for managing users #345
Merged
QuantumEntangledAndy
merged 5 commits into
QuantumEntangledAndy:master
from
ecksun:feature/users
Jan 30, 2025
Merged
Add support for managing users #345
QuantumEntangledAndy
merged 5 commits into
QuantumEntangledAndy:master
from
ecksun:feature/users
Jan 30, 2025
+600
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seemed to be a child of AbilitySupport, which is not the case
ecksun
commented
Jan 27, 2025
QuantumEntangledAndy
requested changes
Jan 28, 2025
It is used to manage users
Support includes: - Listing users - Creating users - Deleting users - Changing the password of users
Thank you for the feedback! it made the code much better |
Skip deser the pass field for camera's that try to sent it in the user list
QuantumEntangledAndy
approved these changes
Jan 30, 2025
QuantumEntangledAndy
merged commit Jan 30, 2025
6e05e78
into
QuantumEntangledAndy:master
15 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #303
Reference: #342
I would have preferred to have different types for the different operations but I couldn't find an easy way of modeling that in BcXml (for example
user_id
is not included when creating a user)