Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump antlr #111

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Bump antlr #111

merged 7 commits into from
Nov 2, 2023

Conversation

svengiegerich
Copy link
Contributor

Motivation: Bump antlr version from 4.11 to 4.13

Changes: Bump version, and ran helper_generate_grammar_targets.sh

@svengiegerich svengiegerich self-assigned this Oct 30, 2023
@svengiegerich
Copy link
Contributor Author

svengiegerich commented Oct 30, 2023 •
edited
Loading

@ivergara, sorry for bothering again with the pre-commits, but now it's also failing here (while they work for me locally).
Is it maybe me that introduces smth weird locally?

My env:

# Name                    Version                   Build  Channel
alabaster                 0.7.13             pyhd8ed1ab_0    conda-forge
antlr4-python3-runtime    4.11.1                   pypi_0    pypi
babel                     2.12.1             pyhd8ed1ab_1    conda-forge
brotlipy                  0.7.0           py311he2be06e_1005    conda-forge
bzip2                     1.0.8                h3422bc3_4    conda-forge
ca-certificates           2023.7.22            hf0a4a13_0    conda-forge
certifi                   2023.7.22          pyhd8ed1ab_0    conda-forge
cffi                      1.15.1          py311hae827db_3    conda-forge
cfgv                      3.3.1              pyhd8ed1ab_0    conda-forge
charset-normalizer        3.1.0              pyhd8ed1ab_0    conda-forge
click                     8.1.3           unix_pyhd8ed1ab_2    conda-forge
colorama                  0.4.6              pyhd8ed1ab_0    conda-forge
coverage                  7.2.3           py311he2be06e_0    conda-forge
cryptography              40.0.2          py311h507f6e9_0    conda-forge
distlib                   0.3.6              pyhd8ed1ab_0    conda-forge
docutils                  0.17.1          py311h267d04e_3    conda-forge
exceptiongroup            1.1.1              pyhd8ed1ab_0    conda-forge
filelock                  3.12.0             pyhd8ed1ab_0    conda-forge
greenlet                  2.0.2           py311ha397e9f_0    conda-forge
identify                  2.5.22             pyhd8ed1ab_0    conda-forge
idna                      3.4                pyhd8ed1ab_0    conda-forge
imagesize                 1.4.1              pyhd8ed1ab_0    conda-forge
importlib-metadata        6.6.0              pyha770c72_0    conda-forge
iniconfig                 2.0.0              pyhd8ed1ab_0    conda-forge
jinja2                    3.1.2              pyhd8ed1ab_1    conda-forge
libcxx                    16.0.2               h4653b0c_0    conda-forge
libedit                   3.1.20191231         hc8eb9b7_2    conda-forge
libexpat                  2.5.0                hb7217d7_1    conda-forge
libffi                    3.4.2                h3422bc3_5    conda-forge
libiconv                  1.17                 he4db4b2_0    conda-forge
libsqlite                 3.40.0               h76d750c_1    conda-forge
libzlib                   1.2.13               h03a7124_4    conda-forge
make                      4.3                  he57ea6c_1    conda-forge
markupsafe                2.1.2           py311he2be06e_0    conda-forge
ncurses                   6.3                  h07bb92c_1    conda-forge
nodeenv                   1.7.0              pyhd8ed1ab_0    conda-forge
numpydoc                  1.5.0              pyhd8ed1ab_0    conda-forge
openjdk                   17.0.3               hf913c23_6    conda-forge
openssl                   3.1.4                h0d3ecfb_0    conda-forge
packaging                 23.1               pyhd8ed1ab_0    conda-forge
pbr                       5.11.1             pyhd8ed1ab_0    conda-forge
pip                       23.1.1             pyhd8ed1ab_0    conda-forge
platformdirs              3.2.0              pyhd8ed1ab_0    conda-forge
pluggy                    1.0.0              pyhd8ed1ab_5    conda-forge
pre-commit                3.2.2              pyha770c72_0    conda-forge
pycparser                 2.21               pyhd8ed1ab_0    conda-forge
pygments                  2.15.1             pyhd8ed1ab_0    conda-forge
pyodbc                    4.0.38          py311ha397e9f_0    conda-forge
pyopenssl                 23.1.1             pyhd8ed1ab_0    conda-forge
pysocks                   1.7.1              pyha2e5f31_6    conda-forge
pytest                    7.3.1              pyhd8ed1ab_0    conda-forge
pytest-cov                4.0.0              pyhd8ed1ab_0    conda-forge
pytest-mock               3.10.0             pyhd8ed1ab_0    conda-forge
python                    3.11.3          h1456518_0_cpython    conda-forge
python_abi                3.11                    3_cp311    conda-forge
pytsql                    1.2.1.dev1698650588+dirty          pypi_0    pypi
pytz                      2023.3             pyhd8ed1ab_0    conda-forge
pyyaml                    6.0             py311he2be06e_5    conda-forge
readline                  8.2                  h92ec313_1    conda-forge
requests                  2.28.2             pyhd8ed1ab_1    conda-forge
setuptools                67.7.2             pyhd8ed1ab_0    conda-forge
setuptools-scm            7.1.0              pyhd8ed1ab_0    conda-forge
setuptools_scm            7.1.0                hd8ed1ab_0    conda-forge
snowballstemmer           2.2.0              pyhd8ed1ab_0    conda-forge
speedy-antlr-tool         1.4.3              pyhd8ed1ab_0    conda-forge
sphinx                    5.3.0              pyhd8ed1ab_0    conda-forge
sphinx_rtd_theme          1.2.0              pyha770c72_0    conda-forge
sphinxcontrib-apidoc      0.3.0                      py_1    conda-forge
sphinxcontrib-applehelp   1.0.4              pyhd8ed1ab_0    conda-forge
sphinxcontrib-devhelp     1.0.2                      py_0    conda-forge
sphinxcontrib-htmlhelp    2.0.1              pyhd8ed1ab_0    conda-forge
sphinxcontrib-jquery      4.1                pyhd8ed1ab_0    conda-forge
sphinxcontrib-jsmath      1.0.1                      py_0    conda-forge
sphinxcontrib-qthelp      1.0.3                      py_0    conda-forge
sphinxcontrib-serializinghtml 1.1.5              pyhd8ed1ab_2    conda-forge
sqlalchemy                2.0.10          py311heffc1b2_0    conda-forge
tk                        8.6.12               he1e0b03_0    conda-forge
toml                      0.10.2             pyhd8ed1ab_0    conda-forge
tomli                     2.0.1              pyhd8ed1ab_0    conda-forge
typing-extensions         4.5.0                hd8ed1ab_0    conda-forge
typing_extensions         4.5.0              pyha770c72_0    conda-forge
tzdata                    2023c                h71feb2d_0    conda-forge
ukkonen                   1.0.1           py311hd6ee22a_3    conda-forge
unixodbc                  2.3.10               hb39ff51_0    conda-forge
urllib3                   1.26.15            pyhd8ed1ab_0    conda-forge
virtualenv                20.22.0            pyhd8ed1ab_0    conda-forge
wheel                     0.40.0             pyhd8ed1ab_0    conda-forge
xz                        5.2.6                h57fd34a_0    conda-forge
yaml                      0.2.5                h3422bc3_2    conda-forge
zipp                      3.15.0             pyhd8ed1ab_0    conda-forge
```

@svengiegerich svengiegerich marked this pull request as ready for review October 30, 2023 09:11
@svengiegerich svengiegerich changed the base branch from main to sg_use_ruff October 31, 2023 14:47
@svengiegerich
Copy link
Contributor Author

Update: Switching to ruff (PR #112) seems to solve this weird issue... 🙌

@svengiegerich svengiegerich mentioned this pull request Oct 31, 2023
Merged
Base automatically changed from sg_use_ruff to main November 1, 2023 07:14
@svengiegerich svengiegerich merged commit 29929e4 into main Nov 2, 2023
17 of 18 checks passed
@svengiegerich svengiegerich deleted the sg_bump_antlr branch November 2, 2023 17:13
@svengiegerich svengiegerich mentioned this pull request Nov 13, 2023
Merged
svengiegerich added a commit that referenced this pull request Nov 13, 2023
@svengiegerich
Reflect PR #111 in update_grammar.yml (#115)
94a710d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivergara ivergara ivergara approved these changes

@kklein kklein Awaiting requested review from kklein

@SimeonStoykovQC SimeonStoykovQC Awaiting requested review from SimeonStoykovQC

Assignees

@svengiegerich svengiegerich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svengiegerich @ivergara