Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: AlgoSeekFutures Converter #7864

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Mar 20, 2024

Description

This pull request removes the AlgoSeekFuturesConverter from the ToolBox program. This code is deemed outdated and unused, contributing to a cleaner and more streamlined codebase.

Related Issue

N/A

Motivation and Context

The AlgoSeekFuturesConverter functionality has become obsolete and no longer serves a purpose within the ToolBox program. Removing it will not only declutter the codebase but also improve maintainability and understanding for future developers working on the project. This action aligns with our ongoing efforts to ensure that our codebase remains efficient and relevant to current needs.

Requires Documentation Change

N/A

How Has This Been Tested?

To ensure the integrity of the update, the following steps were taken:

  1. Old Test Execution: The existing test suite was run to verify the functionality prior to the update.
  2. Regression Testing: A thorough regression test was conducted to ensure that the changes did not introduce any new issues or conflicts.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Martin-Molinero
Copy link
Member

Same as #7559 we can't merge this yet until new converter is operational 👍

@Romazes Romazes deleted the remove-extra-old-algoseek-futures-format branch March 26, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants