Skip to content

Commit

Permalink
Merge pull request #35 from jhonabreul/refactor-normalize-namespaces
Browse files Browse the repository at this point in the history
Normalize namespace to match all other Lean brokerages
  • Loading branch information
jhonabreul authored Feb 29, 2024
2 parents 2759a9a + 1fa72e6 commit 80ca92e
Show file tree
Hide file tree
Showing 63 changed files with 91 additions and 136 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gh-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ jobs:
run: dotnet build /p:Configuration=Release /v:quiet /p:WarningLevel=1 QuantConnect.BinanceBrokerage.sln

- name: Run Tests
run: dotnet test ./QuantConnect.BinanceBrokerage.Tests/bin/Release/QuantConnect.BinanceBrokerage.Tests.dll
run: dotnet test ./QuantConnect.BinanceBrokerage.Tests/bin/Release/QuantConnect.Brokerages.Binance.Tests.dll
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

using Moq;
using NUnit.Framework;
using QuantConnect.Brokerages;
using QuantConnect.Configuration;
using QuantConnect.Interfaces;
using QuantConnect.Lean.Engine.DataFeeds;
Expand All @@ -24,7 +23,7 @@
using QuantConnect.Util;
using System;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public class BinanceBrokerageAdditionalTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
using System;
using System.Threading;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public partial class BinanceBrokerageTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@

using NUnit.Framework;
using QuantConnect.Logging;
using QuantConnect.BinanceBrokerage.ToolBox;
using QuantConnect.Brokerages.Binance.ToolBox;
using System;
using System.Linq;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public class BinanceBrokerageExchangeInfoTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

using NodaTime;
using NUnit.Framework;
using QuantConnect.Brokerages;
using QuantConnect.Configuration;
using QuantConnect.Data;
using QuantConnect.Data.Market;
Expand All @@ -26,7 +25,7 @@
using System;
using System.Linq;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public class BinanceBrokerageHistoryProviderTests
Expand Down
3 changes: 1 addition & 2 deletions QuantConnect.BinanceBrokerage.Tests/BinanceBrokerageTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,14 @@
using NUnit.Framework;
using QuantConnect.Configuration;
using Moq;
using QuantConnect.Brokerages;
using QuantConnect.Tests.Common.Securities;
using QuantConnect.Orders;
using QuantConnect.Logging;
using System.Threading;
using QuantConnect.Lean.Engine.DataFeeds;
using QuantConnect.Tests.Brokerages;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public partial class BinanceBrokerageTests : BrokerageTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using NUnit.Framework;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public partial class BinanceCoinFuturesBrokerageTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,10 @@
using System;
using NUnit.Framework;
using QuantConnect.Tests;
using QuantConnect.Brokerages;
using QuantConnect.Configuration;
using QuantConnect.Lean.Engine.DataFeeds;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public class BinanceCoinFuturesBrokerageHistoryProviderTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,14 @@
using System;
using System.Linq;
using NUnit.Framework;
using QuantConnect.Brokerages;
using QuantConnect.Interfaces;
using QuantConnect.Securities;
using QuantConnect.Configuration;
using QuantConnect.Tests.Brokerages;
using QuantConnect.Lean.Engine.DataFeeds;
using QuantConnect.Tests.Common.Securities;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public partial class BinanceCoinFuturesBrokerageTests : BrokerageTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using NUnit.Framework;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public partial class BinanceFuturesBrokerageTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,10 @@
using System;
using NUnit.Framework;
using QuantConnect.Tests;
using QuantConnect.Brokerages;
using QuantConnect.Configuration;
using QuantConnect.Lean.Engine.DataFeeds;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public class BinanceFuturesBrokerageHistoryProviderTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,14 @@
using System;
using System.Linq;
using NUnit.Framework;
using QuantConnect.Brokerages;
using QuantConnect.Interfaces;
using QuantConnect.Securities;
using QuantConnect.Configuration;
using QuantConnect.Tests.Brokerages;
using QuantConnect.Lean.Engine.DataFeeds;
using QuantConnect.Tests.Common.Securities;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public partial class BinanceFuturesBrokerageTests : BrokerageTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,11 @@

using System;
using NUnit.Framework;
using QuantConnect.Brokerages;
using QuantConnect.Configuration;
using QuantConnect.Interfaces;
using QuantConnect.Lean.Engine.DataFeeds;
using QuantConnect.Util;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public class BinanceUSBrokerageAdditionalTests : BinanceBrokerageAdditionalTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
using NUnit.Framework;
using QuantConnect.Tests;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public partial class BinanceUSBrokerageTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,12 @@
*/

using NUnit.Framework;
using QuantConnect.Brokerages;
using QuantConnect.Configuration;
using QuantConnect.Lean.Engine.DataFeeds;
using QuantConnect.Tests;
using System;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public class BinanceUSBrokerageHistoryProviderTests : BinanceBrokerageHistoryProviderTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

using Moq;
using NUnit.Framework;
using QuantConnect.Brokerages;
using QuantConnect.Configuration;
using QuantConnect.Interfaces;
using QuantConnect.Lean.Engine.DataFeeds;
Expand All @@ -25,7 +24,7 @@
using System;
using System.Linq;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public partial class BinanceUSBrokerageTests : BinanceBrokerageTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
using System.Linq;
using Newtonsoft.Json;
using NUnit.Framework;
using QuantConnect.BinanceBrokerage.Converters;
using QuantConnect.BinanceBrokerage.Messages;
using QuantConnect.Brokerages.Binance.Converters;
using QuantConnect.Brokerages.Binance.Messages;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public class MarginAccountConverterTests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
<Copyright>Copyright © 2021</Copyright>
<TestProjectType>UnitTest</TestProjectType>
<OutputPath>bin\$(Configuration)\</OutputPath>
<Product>QuantConnect.BinanceBrokerage.Tests</Product>
<AssemblyName>QuantConnect.BinanceBrokerage.Tests</AssemblyName>
<RootNamespace>QuantConnect.BinanceBrokerage.Tests</RootNamespace>
<AssemblyTitle>QuantConnect.BinanceBrokerage.Tests</AssemblyTitle>
<Product>QuantConnect.Brokerages.Binance.Tests</Product>
<AssemblyName>QuantConnect.Brokerages.Binance.Tests</AssemblyName>
<RootNamespace>QuantConnect.Brokerages.Binance.Tests</RootNamespace>
<AssemblyTitle>QuantConnect.Brokerages.Binance.Tests</AssemblyTitle>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
using System.Linq;
using Newtonsoft.Json;
using NUnit.Framework;
using QuantConnect.BinanceBrokerage.Converters;
using QuantConnect.BinanceBrokerage.Messages;
using QuantConnect.Brokerages.Binance.Converters;
using QuantConnect.Brokerages.Binance.Messages;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public class SpotAccountConverterTests
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.BinanceBrokerage.Tests/TestSetup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
using QuantConnect.Logging;
using QuantConnect.Configuration;

namespace QuantConnect.BinanceBrokerage.Tests
namespace QuantConnect.Brokerages.Binance.Tests
{
[TestFixture]
public class TestSetup
Expand Down
4 changes: 1 addition & 3 deletions QuantConnect.BinanceBrokerage.ToolBox/BaseDataDownloader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,14 @@
*/

using NodaTime;
using QuantConnect.Brokerages;
using QuantConnect.Data;
using QuantConnect.Data.Market;
using QuantConnect.Securities;
using QuantConnect.Util;
using System;
using System.Collections.Generic;
using System.Linq;

namespace QuantConnect.BinanceBrokerage.ToolBox
namespace QuantConnect.Brokerages.Binance.ToolBox
{
/// <summary>
/// Binance Downloader class
Expand Down
11 changes: 1 addition & 10 deletions QuantConnect.BinanceBrokerage.ToolBox/BinanceDataDownloader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,9 @@
* limitations under the License.
*/

using NodaTime;
using QuantConnect.Brokerages;
using QuantConnect.Configuration;
using QuantConnect.Data;
using QuantConnect.Data.Market;
using QuantConnect.Securities;
using QuantConnect.Util;
using System;
using System.Collections.Generic;
using System.Linq;

namespace QuantConnect.BinanceBrokerage.ToolBox
namespace QuantConnect.Brokerages.Binance.ToolBox
{
/// <summary>
/// Binance Downloader class
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
using Newtonsoft.Json;
using QuantConnect.ToolBox;
using System.Collections.Generic;
using QuantConnect.BinanceBrokerage.ToolBox.Models;
using QuantConnect.Brokerages.Binance.ToolBox.Models;

namespace QuantConnect.BinanceBrokerage.ToolBox
namespace QuantConnect.Brokerages.Binance.ToolBox
{
/// <summary>
/// Binance implementation of <see cref="IExchangeInfoDownloader"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,9 @@
* limitations under the License.
*/

using NodaTime;
using QuantConnect.Brokerages;
using QuantConnect.Configuration;
using QuantConnect.Data;
using QuantConnect.Data.Market;
using QuantConnect.Securities;
using System;
using System.Collections.Generic;
using System.Linq;

namespace QuantConnect.BinanceBrokerage.ToolBox
namespace QuantConnect.Brokerages.Binance.ToolBox
{
/// <summary>
/// BinanceUS Downloader class
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*
*/

namespace QuantConnect.BinanceBrokerage.ToolBox.Models
namespace QuantConnect.Brokerages.Binance.ToolBox.Models
{
/// <summary>
/// Represents Binance exchange info response
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.BinanceBrokerage.ToolBox/Models/Symbol.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;

namespace QuantConnect.BinanceBrokerage.ToolBox.Models
namespace QuantConnect.Brokerages.Binance.ToolBox.Models
{
/// <summary>
/// Represents Binance exchange info for symbol
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.BinanceBrokerage.ToolBox/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
using QuantConnect.Util;
using static QuantConnect.Configuration.ApplicationParser;

namespace QuantConnect.BinanceBrokerage.ToolBox
namespace QuantConnect.Brokerages.Binance.ToolBox
{
static class Program
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
<TargetFramework>net6.0</TargetFramework>
<Copyright>Copyright © 2021</Copyright>
<OutputPath>bin\$(Configuration)\</OutputPath>
<Product>QuantConnect.BinanceBrokerage.ToolBox</Product>
<AssemblyName>QuantConnect.BinanceBrokerage.ToolBox</AssemblyName>
<RootNamespace>QuantConnect.BinanceBrokerage.ToolBox</RootNamespace>
<AssemblyTitle>QuantConnect.BinanceBrokerage.ToolBox</AssemblyTitle>
<Product>QuantConnect.Brokerages.Binance.ToolBox</Product>
<AssemblyName>QuantConnect.Brokerages.Binance.ToolBox</AssemblyName>
<RootNamespace>QuantConnect.Brokerages.Binance.ToolBox</RootNamespace>
<AssemblyTitle>QuantConnect.Brokerages.Binance.ToolBox</AssemblyTitle>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
Expand Down
5 changes: 2 additions & 3 deletions QuantConnect.BinanceBrokerage/BinanceBaseRestApiClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@

using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using QuantConnect.BinanceBrokerage.Messages;
using QuantConnect.Brokerages;
using QuantConnect.Brokerages.Binance.Messages;
using QuantConnect.Logging;
using QuantConnect.Orders;
using QuantConnect.Orders.Fees;
Expand All @@ -32,7 +31,7 @@
using System.Text;
using Order = QuantConnect.Orders.Order;

namespace QuantConnect.BinanceBrokerage
namespace QuantConnect.Brokerages.Binance
{
/// <summary>
/// Binance REST API base implementation
Expand Down
Loading

0 comments on commit 80ca92e

Please sign in to comment.