Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCVL-793 Compute partial fidelity #512

Merged

Conversation

Benoit-F-Q
Copy link
Contributor

No description provided.

@Aubaert
Copy link
Contributor

Aubaert commented Jan 15, 2025

Since we now have a method that relies on computing the fidelity on a submatrix, we should change the fidelity method to accept this new parameter in the norm that is defined in perceval (path is utils\algorithms\norm.py), and also maybe the other metrics in this file.
This would allow the users to get what the optimizer gave them using only the result and the target, as it is the case today.

perceval/utils/algorithms/norm.py Outdated Show resolved Hide resolved
perceval/utils/algorithms/norm.py Show resolved Hide resolved
perceval/utils/algorithms/norm.py Outdated Show resolved Hide resolved
perceval/utils/algorithms/norm.py Outdated Show resolved Hide resolved
perceval/utils/algorithms/norm.py Outdated Show resolved Hide resolved
perceval/utils/algorithms/norm.py Show resolved Hide resolved
@Aubaert
Copy link
Contributor

Aubaert commented Jan 16, 2025

Also, can you add tests for the norm computations with empty modes ?

@Benoit-F-Q Benoit-F-Q merged commit 57b89a9 into Quandela:release/0.12.1 Jan 22, 2025
3 of 4 checks passed
Benoit-F-Q added a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants