Pcvl 833 use heralds at first step of feed forward #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap Configurators directly (making the modes linked consistent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change (that was almost necessary): FFCircuitProvider can no longer be fed with AFFConfigurators (we must use a Processor to do so). This ensures that the circuit size of the FFCircuitProvider completely includes the configured circuits of the AFFConfigurator.
Performance checks:
On the feed-forward notebook:
(Note that the notebook is not using mask since it has a StateVector as input, so we will have gains most of the time, and always when using ancillary modes)