Simplify tautologies #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #30 |
blyxxyz
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
LGTM.
Another solution might be to give .model_count() a names argument so it can adjust for excluded names. But this is simpler and more broadly useful.
You could add a hypothesis test case that runs .to_CNF(simplify_tautologies=False) and checks that no names were lost.
|
Great idea! It caught a corner case where |
|
Ah! I hadn't spotted that. My only concern now is that the name |
|
Ah, right. Just |
blyxxyz
requested changes
Dec 11, 2022
Co-authored-by: Jan Verbeek <[email protected]>
|
Thanks, @blyxxyz ! Should be all set to go if you want to approve/merge. |
blyxxyz
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is to allow for tautologies in
to_CNFconversions so that model counts aren't thrown off (variables mentioned in a tautological clause will be missing from the compilation).