Skip to content

Commit

Permalink
Add a note to the caveats about issue #1 (slow equality checks)
Browse files Browse the repository at this point in the history
  • Loading branch information
blyxxyz committed Jul 5, 2019
1 parent 2dfde3b commit aca180c
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions docs/caveats.rst
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,10 @@ Decomposability is automatically detected. However, you can skip the check if yo
Determinism is too expensive to automatically detect, but it can give a huge speedup. If you know a sentence to be deterministic, pass ``deterministic=True`` as a keyword argument to take advantage.

A compiler like `DSHARP <https://bitbucket.org/haz/dsharp>`_ may be able to convert some sentences into equivalent deterministic decomposable sentences. The output of DSHARP can be loaded using the :mod:`nnf.dsharp` module.

Other duplication inefficiencies
--------------------------------

Even when properly deduplicated, the kind of sentence that's vulnerable to node duplication might still be inefficient to work with for some operations.

A known offender is equality (``==``). Currently, if two of such sentences are compared that are equal but don't share any objects, it takes a very long time even both sentences don't have any duplication within themselves.

0 comments on commit aca180c

Please sign in to comment.