latex-source (and latex) circuit drawer support for standalone (and cleaner output) #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshDumo
requested review from
nkanazawa1989,
nonhermitian and
a team
as code owners
|
|
|
nice hack! (I just took the freedom of blacking and removing the commented lines, have a look and feel free to revert) |
|
Nicely done @JoshDumo . I just have one small observation. When the qc = QuantumCircuit(2)
qc.h([0])
qc.cx(0,1)
qc.draw('latex', initial_state=True)gives an output like
Could you please check on that? |
There was a problem hiding this comment.
Hi @JoshDumo . The output looks good now. I just had a few pointers.
|
Thanks @JoshDumo . The fix looks great! Nice find on the scaling. Blacking should help pass the tests. |
javabster
added
the
Changelog: New Feature
1ucian0
changed the title
1ucian0
changed the title
TharrmashasthaPV
added a commit
to TharrmashasthaPV/qiskit-terra
that referenced
this pull request
Jun 28, 2021
mergify bot
pushed a commit
that referenced
this pull request
Sep 23, 2021
…conditioning (#6248) * Cbit conditional * lint fixed * q * added_tests * Added tests * lint fix * lint-fix * added extra test * latex drawer for single bit cond * fixed small errors * Minor fix * Added extra test * Added reno and a small lint fix * Fixed reno * lint fix * References refactored for #6483 * Suggested changes * Corrected failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #6447 and some of CQuIC/qcircuit#41
Details and comments
circuit.draw("latex_source") was not using standalone, so the output was a full page. Also had some several optional lines cluttering the tex code output.
Modified latex.py to make the latex drawer use standalone. Removed any extra output lines of tex code.
To deal with cropping, hacked the output by adding nghost{} with the name of the qubit to give extra tabbing before the labels. Also added a new line at the top and the bottom of the Qcircuit.
Generated new Test tex files according to the new tex code output program.