Reorganize sourcegen from crate to submodule in oq3_syntax
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sourcegen crate was published by rust-analyzer. But it was broken, I pointed this out and they said publishing at all was a mistake and removed it. So we copied the crate into our workspace. But in fact it is one file, used in one crate (oq3_syntax). So we move the code to a module (a file) in oq3_syntax.
jlapeyre
added a commit
to mtreinish/openqasm3_parser
that referenced
this pull request
Jan 13, 2024
jlapeyre
added a commit
that referenced
this pull request
Jan 21, 2024
* Add CI workflow to publish crates on tag/release This commit adds a new github actions work to publish the package's crates to crates.io. This new CI job run cargo publish on the respective crates in the correct order to publish the entire workspace. * Update package dirs after #13 and #15 * Update package dirs after #27 * Choose names that better describe actions taken * Put list of crates to release (publish on crates.io) in topo order --------- Co-authored-by: John Lapeyre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sourcegen crate was published by rust-analyzer. But it was broken, I pointed this out and they said publishing at all was a mistake and removed it (or stopped publishing it).
So we copied the crate into our workspace. But in fact it is one file, used in one crate (
oq3_syntax). So we move the code to a module (a file) inoq3_syntaxand deleted the crate.