Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Qiskit release notes ToC settings #965

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

arnaucasau
Copy link
Collaborator

@arnaucasau arnaucasau commented Mar 5, 2024

Closes #941

This PR sets the in_page_toc_max_heading_level to 4 for legacy versions of qiskit (< 0.45) and to 3 for 0.45+ versions. It also changes the description of all the release notes to match the one we are using in the API generation script: Changes made in Qiskit {version}

Given that we don't regenerate legacy release notes using the script, we can set the in_page_toc_max_heading_level to 3 for all qiskit versions and 2 for the rest of the APIs.

The changes to the latest release note were done by removing the file and regenerating the 1.0.1 version. The rest of the files we manually updated.

@arnaucasau arnaucasau marked this pull request as ready for review March 5, 2024 18:00
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks

@arnaucasau arnaucasau added this pull request to the merge queue Mar 5, 2024
Merged via the queue into Qiskit:main with commit d8e9788 Mar 5, 2024
5 checks passed
@arnaucasau arnaucasau deleted the release-notes-heading branch March 5, 2024 18:24
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Closes Qiskit#941

This PR sets the `in_page_toc_max_heading_level` to 4 for legacy
versions of qiskit (< 0.45) and to 3 for 0.45+ versions. It also changes
the description of all the release notes to match the one we are using
in the API generation script: `Changes made in Qiskit {version}`

Given that we don't regenerate legacy release notes using the script, we
can set the `in_page_toc_max_heading_level` to 3 for all qiskit versions
and 2 for the rest of the APIs.

The changes to the latest release note were done by removing the file
and regenerating the 1.0.1 version. The rest of the files we manually
updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve page table of contents settings for Qiskit release notes
3 participants