Split out InternalLink and ExternalLink classes
#882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
force-pushed
the
EA/refactor-link-checker
branch
from
3bfe8dd to
457a248
Compare
frankharkins
approved these changes
Feb 26, 2024
Comment on lines
+39
to
+41
| const response = await fetch(this.value, { | ||
| headers: { "User-Agent": "qiskit-documentation-broken-links-finder" }, | ||
| }); |
There was a problem hiding this comment.
Not technically part of this PR, but should we be using method: "HEAD" here to avoid downloading the body? Might make things faster and reduce rate limiting if we're not doing that already.
There was a problem hiding this comment.
Oh, that's a great idea! I'll fix in a follow up.
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
We decided as part of Qiskit#876 that we should have distinct programs for checking internal vs external links, since they are such distinct workflows. This PR is a refactor to prepare for that change. The link checker program still behaves the same as before; this is only a refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided as part of #876 that we should have distinct programs for checking internal vs external links, since they are such distinct workflows.
This PR is a refactor to prepare for that change. The link checker program still behaves the same as before; this is only a refactor.