Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure cspell to use dictionaries #873

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Reconfigure cspell to use dictionaries #873

merged 6 commits into from
Feb 23, 2024

Conversation

kaelynj
Copy link
Collaborator

@kaelynj kaelynj commented Feb 22, 2024

Closes #827

@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

@Eric-Arellano
Copy link
Collaborator

Thanks @kaelynj! Try merging main and I'm wondering if it will work thanks to Abby C's PR that was just merged. Otherwise, it'd be good to have it be a dedicated PR as a precursor.

@Eric-Arellano
Copy link
Collaborator

Oh, @kaelynj the issue is that it's checking the docs under api/{qiskit,qiskit-ibm-provider,qiskit-ibm-runtime}. Those should be ignored.

@kaelynj
Copy link
Collaborator Author

kaelynj commented Feb 23, 2024

Oh, @kaelynj the issue is that it's checking the docs under api/{qiskit,qiskit-ibm-provider,qiskit-ibm-runtime}. Those should be ignored.

Should be fixed now! Had to fix formatting, but now it should be fixed 😅

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for updating the README also. Looks great :)

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit 1a15134 Feb 23, 2024
2 checks passed
@Eric-Arellano Eric-Arellano deleted the kjf/spellcheck branch February 23, 2024 16:04
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Better configure cspell by using dictionaries
3 participants