Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link checker: One release note per FileBatch #862

Merged
merged 6 commits into from
Feb 22, 2024

Conversation

arnaucasau
Copy link
Collaborator

Part of #755

This PR changes how we are checking the links of the Qiskit release notes. The link checker will check every file in a different batch allowing us to load all the necessary files for each release note.

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This is complex logic but your code is easy to follow.

scripts/commands/checkLinks.ts Outdated Show resolved Hide resolved
scripts/commands/checkLinks.ts Outdated Show resolved Hide resolved
scripts/commands/checkLinks.ts Show resolved Hide resolved
scripts/commands/checkLinks.ts Outdated Show resolved Hide resolved
scripts/commands/checkLinks.ts Show resolved Hide resolved
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arnaucasau arnaucasau added this pull request to the merge queue Feb 22, 2024
@arnaucasau arnaucasau removed this pull request from the merge queue due to a manual request Feb 22, 2024
@arnaucasau arnaucasau added this pull request to the merge queue Feb 22, 2024
Merged via the queue into Qiskit:main with commit d0d87a6 Feb 22, 2024
2 checks passed
@arnaucasau arnaucasau deleted the AC/check-release-notes branch February 22, 2024 18:35
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Part of Qiskit#755 

This PR changes how we are checking the links of the Qiskit release
notes. The link checker will check every file in a different batch
allowing us to load all the necessary files for each release note.

---------

Co-authored-by: Eric Arellano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants