Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete stale images #2529

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Delete stale images #2529

merged 5 commits into from
Dec 23, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

Found with npx tsx scripts/js/commands/checkStaleImages.ts. CI's link checker will validate that no images were removed that shouldn't have been.

arnaucasau
arnaucasau previously approved these changes Dec 23, 2024
Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@Eric-Arellano Eric-Arellano dismissed arnaucasau’s stale review December 23, 2024 19:14

Made a non-trivial change to the gen-api script, which needs review

Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call early returning when downloading the release notes' images for the dev version!

scripts/js/lib/api/saveImages.ts Outdated Show resolved Hide resolved
@Eric-Arellano Eric-Arellano added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 33a35b5 Dec 23, 2024
4 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/rm-stale branch December 23, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants