Fix performance of stale image check #2528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2518.
We were before checking every image inside
await Promise.all()
and only logging results at the end. This is too slow to keep that much in memory, and it results in the experience feeling laggy to not get results until the very end.Instead, it makes more sense to check one image at a time and eagerly report violations.
Other improvements in this PR:
npx tsx
, so it should be fine.example run