[Suggestion] Don't commit images with low visual change in dev docs sync #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for now after discussion with team. |
For posterity, it was closed because of concerns that we would miss changes like the label for a Gate changing. It's tricky to get the threshold right, and we found it tricky in qiskit-sphinx-theme with visual regression testing. We may want to make this change, but we should start with #2517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment to avoid diffs for images with basically no change. Threshold was chosen by eyeballing. Here's two examples:
Example below similarity threshold
Example above similarity threshold
