Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout in serverless tests #2402

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

frankharkins
Copy link
Member

This notebook was regularly timing out in CI. This PR removes the manual polling/timeout and just polls until the cell times out.

  • In CI, it'll time out after 300s (an increase from 100s).
  • In the fortnightly cron job, it'll wait until the action timesout at 6hrs.

If this is still causing problems, we can remove it from CI.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, but it might be worth logging because otherwise people won't know why the program appears hung. The logs are helpful in CI debugging, and especially when running locally.

Maybe log every 15 seconds the result of the status, or even every 20? Don't log the first time. Mention the notebook name.

@frankharkins
Copy link
Member Author

Any logs we add in the notebook won't be seen by users executing through the script. We don't echo things printed in notebooks to the tester script as it's not trivial with nbformat and it would be super noisy. The only things we do pass along are exceptions because nbformat makes that easy, and warnings which we find by inspecting the notebook after its finished running.

@frankharkins frankharkins added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit c78c765 Dec 2, 2024
4 checks passed
@frankharkins frankharkins deleted the FH/serverless-timeout branch December 2, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants