Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2330.
FYI: attributes don't have modifiers
Our old code would try to remove modifiers for
py.attribute
, but that was not necessary because they cannot be set. (An attribute is the default, like setting a value in__init__
; a property is when you set@property
on a function)Modifiers are only set on properties. This is evidenced by
npm run regen-api
not changing despite removing code to handlepy.attribute
.PR does not preserve
property
modifierFor a typical end-user, an attribute and
property
are essentially the same. The only time I think it'd be relevant is if you're subclassing the class; otherwise, I thinkproperty
is distracting.So, we continue to not preserve
property
, the same as before.abstract
vsabstract property
We capture the whole
abstract property
because the phrase is much more meaningful thanabstract
.