Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle abstract properties #2333

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Handle abstract properties #2333

merged 3 commits into from
Nov 18, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Nov 15, 2024

Part of #2330.

Screenshot 2024-11-15 at 4 40 29 PM

FYI: attributes don't have modifiers

Our old code would try to remove modifiers for py.attribute, but that was not necessary because they cannot be set. (An attribute is the default, like setting a value in __init__; a property is when you set @property on a function)

Modifiers are only set on properties. This is evidenced by npm run regen-api not changing despite removing code to handle py.attribute.

PR does not preserve property modifier

For a typical end-user, an attribute and property are essentially the same. The only time I think it'd be relevant is if you're subclassing the class; otherwise, I think property is distracting.

So, we continue to not preserve property, the same as before.

abstract vs abstract property

We capture the whole abstract property because the phrase is much more meaningful than abstract.

@Eric-Arellano
Copy link
Collaborator Author

This is safe to merge even before we teach closed source to handle modifiers. The app will simply ignore the value.

Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thank you!

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 113a406 Nov 18, 2024
3 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/abstract-properties branch November 18, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants