-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guides pages for OBP #2248
Guides pages for OBP #2248
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks Kaelyn, looks great! I'll just drop a few thoughts below for the getting started guide:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a couple of minor comments/requests
Co-authored-by: Caleb Johnson <[email protected]>
I have a few suggested edits to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copyediting suggestions, otherwise good to go
@kaelynj -- pending getting Bryce's suggestions folded in, are you also able to also add in the results for running the backprop and backprop w truncation circuits run on the StatevectorEstimator to isolate the OBP-specific effects? Beyond that, this looks good to me! |
Co-authored-by: abbycross <[email protected]>
This should be included now (along with @BryceFuller's suggestion). @Eric-Arellano I'm having an issue with CI on the |
@kaelynj The tutorial for OBP in Learning Platform just dropped -- would you be able to add a link to this in the "next steps" section of the getting started page? |
Closes #2107 and closes #2108
I'll include the files in the toc and satiate CI once #2148 is merged to avoid dealing with conflicts.