tuning values for rimi generation/execution

QDucasse · Feb 7, 2024 · 2dd39a5 · 2dd39a5
1 parent e535c38
commit 2dd39a5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/tests/rimi/conftest.py b/tests/rimi/conftest.py
@@ -387,7 +387,6 @@ def trace_reg(self, uc_emul, *args, **kwargs):
 
 @pytest.fixture
 def rimi_disasm_setup():
-    # FIXME: Merging dicts with the RIMI info first
     disassembler = Disassembler(RIMI_INSTRUCTIONS_INFO | INSTRUCTIONS_INFO)
     return disassembler
 

diff --git a/tests/rimi/test_rimi_generator.py b/tests/rimi/test_rimi_generator.py
@@ -26,7 +26,7 @@
     [
         (50, 5, 0, 0.2, 0.1, 0.2, 0.01, 1),
         (200, 10, 0.2, 0.4, 0.2, 0.05, 0.2, 2),
-        (10000, 500, 0.5, 0.5, 0.2, 0.1, 0.02, 3),
+        (1000, 50, 0.5, 0.5, 0.2, 0.1, 0.02, 3),
     ],
 )
 def test_execute_shadow_stack_trampoline_generated_binaries(
@@ -103,7 +103,7 @@ def test_execute_shadow_stack_trampoline_generated_binaries(
     [
         (50, 5, 0, 0.2, 0.1, 0.2, 0.01, 1),
         (200, 10, 0.2, 0.4, 0.2, 0.05, 0.2, 2),
-        (10000, 500, 0.5, 0.5, 0.2, 0.1, 0.02, 3),
+        (1000, 50, 0.5, 0.5, 0.2, 0.1, 0.02, 3),
     ],
 )
 def test_execute_full_trampoline_generated_binaries(
@@ -170,8 +170,7 @@ def test_execute_full_trampoline_generated_binaries(
     rimi_handler.hook_exception_tracer(uc_emul)
     rimi_handler.hook_handler(uc_emul)
 
-    # TODO: Rework with new trampolines!
     start_address = INTERPRETER_START_ADDRESS
     end_address = RET_ADDRESS
 
-    start_resumable_emulation(uc_emul, start_address, end_address)  # noqa: F821
+    start_resumable_emulation(uc_emul, start_address, end_address)
diff --git a/tests/rot/conftest.py b/tests/rot/conftest.py
@@ -41,7 +41,6 @@ def handle_rori(self, uc_emul, pc, instr):
 
 @pytest.fixture
 def fixer_disasm_setup():
-    # FIXME: Merging dicts with the ROT info first
     disassembler = Disassembler(ROT_INSTRUCTIONS_INFO | INSTRUCTIONS_INFO)
     return disassembler