-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new fullcalendar #56
base: main
Are you sure you want to change the base?
Conversation
following https://fullcalendar.io/docs/google-calendar this refers to #52
Awesome! Any restriction with the CDN instead of using it "natively"? Also I noticed this comment:
Will that matter? |
no, I just used CDN for simplicity. would you advise having it natively? I'll fix it if you do think that'll be better. ah, don't mind. that's me not cleaning code after myself! |
If CDN works in our case then I would say just stick with it. I kinda don't want to install webpack since we are not using many js packages. |
Well, some interesting discussion about using JS library via CDN on HN |
no CDN? no problem! 👍 do you have any insights into design? |
no, just copying the files locally.
Do you want to adventure into changing the colors?
O
…On Mon, Oct 12, 2020 at 6:28 PM TDHTTTT ***@***.***> wrote:
Not much opinion on calendar design; just keep it simple maybe? As for
using that js library locally, do you plan to use webpack
<https://webpack.js.org/concepts/why-webpack/> or any other bundling
framework?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEL4NAEUGLPYDH3LSZJARVDSKOUMHANCNFSM4SDUTP3Q>
.
|
good to merge? |
following https://fullcalendar.io/docs/google-calendar
this refers to #52 and maybe even #15