Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new fullcalendar #56

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add new fullcalendar #56

wants to merge 3 commits into from

Conversation

omarcostahamido
Copy link
Member

following https://fullcalendar.io/docs/google-calendar
this refers to #52 and maybe even #15

@omarcostahamido omarcostahamido mentioned this pull request Oct 4, 2020
@TDHTTTT
Copy link
Contributor

TDHTTTT commented Oct 4, 2020

Awesome! Any restriction with the CDN instead of using it "natively"? Also I noticed this comment:

     // THIS KEY WON'T WORK IN PRODUCTION!!!
    // To make your own Google API key, follow the directions here:
    // http://fullcalendar.io/docs/google_calendar/

Will that matter?

@omarcostahamido
Copy link
Member Author

no, I just used CDN for simplicity. would you advise having it natively? I'll fix it if you do think that'll be better.

ah, don't mind. that's me not cleaning code after myself!

@TDHTTTT
Copy link
Contributor

TDHTTTT commented Oct 4, 2020

no, I just used CDN for simplicity. would you advise having it natively? I'll fix it if you do think that'll be better.

If CDN works in our case then I would say just stick with it. I kinda don't want to install webpack since we are not using many js packages.

@TDHTTTT
Copy link
Contributor

TDHTTTT commented Oct 11, 2020

Well, some interesting discussion about using JS library via CDN on HN

@omarcostahamido
Copy link
Member Author

omarcostahamido commented Oct 12, 2020

no CDN? no problem! 👍
I'll copy the javascripts soon.

do you have any insights into design?

@TDHTTTT
Copy link
Contributor

TDHTTTT commented Oct 13, 2020

Not much opinion on calendar design; just keep it simple maybe? As for using that js library locally, do you plan to use webpack or any other bundling framework?

This might be a useful reference when implementing.

@omarcostahamido
Copy link
Member Author

omarcostahamido commented Oct 13, 2020 via email

@omarcostahamido omarcostahamido marked this pull request as ready for review December 30, 2020 21:41
@omarcostahamido
Copy link
Member Author

good to merge?

Base automatically changed from master to main March 11, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants