[MRG] Nearest Brenier Potentials #526
Conversation
|
I've added the new module EDIT: created a separate issue #527 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #526 +/- ##
==========================================
+ Coverage 95.99% 96.26% +0.26%
==========================================
Files 65 67 +2
Lines 13816 14040 +224
==========================================
+ Hits 13263 13515 +252
+ Misses 553 525 -28 |
eloitanguy
changed the title
There was a problem hiding this comment.
That is great! I believe those functions are very mapping specific and do not need to appear directly in ot. but except that I think we are ready to merge. Good job @eloitanguy
ot/__init__.py
Outdated
| from .weak import weak_optimal_transport | ||
| from .factored import factored_optimal_transport | ||
| from .solvers import solve | ||
| from .mapping import (nearest_brenier_potential_fit, nearest_brenier_potential_predict_bounds, joint_OT_mapping_kernel, |
There was a problem hiding this comment.
probably not necessary to load them here, those are pretty specific functions (we usually only load generic functions or some that were there before)), same comment below on the lists in text
There was a problem hiding this comment.
Thanks for the review @rflamary!, The last commit addresses your comment, and fixes the example icon. I also made the function ot.mapping._ssnb_qcqp_constants private (added the _), since a user would have no use for this helper function on its own.
…cqp_constants function private
Types of changes
ot.mappingmodule, with a wrapper inot.daand an example in the "other" category.ot.da(now 99%, from about 95% iirc)Motivation and context / Related issue
There was no public implementation of SSNB
How has this been tested (if it applies)
full pytest coverage + example
PR checklist