Alina Layeuskaya #47
Open
Alina Layeuskaya #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
June 1, 2019 14:17
This reverts commit 36f1a91.
AlexeiBuzuma
reviewed
Jun 9, 2019
|
|
||
| def main(): | ||
| parser = create_parser() | ||
| namespace = parser.parse_args(argv[1:]) |
There was a problem hiding this comment.
Зачем использовать sys.argv? ArgumentParser сам знает об аргументах командной строки.
There was a problem hiding this comment.
Согласна. args = parser.parse_args()
AlexeiBuzuma
reviewed
Jun 9, 2019
| import re | ||
| import builtins | ||
|
|
||
| from config import * |
There was a problem hiding this comment.
Импорт через звездочку -- это зло
There was a problem hiding this comment.
Согласна. from config import (LETTERS, DIGITS, ....)
AlexeiBuzuma
reviewed
Jun 9, 2019
| # it's more convenient to do it here in order to simplify parsing to tokens | ||
| if '..' in formula_string: | ||
| print('ERROR: Number can not contain more than one delimiter "." !') | ||
| was_error = True |
There was a problem hiding this comment.
Вместо флагов лучше использовать исключения
There was a problem hiding this comment.
Согласна про исключения и флаги. Не совсем понятно, какие исключения будут возбуждаться здесь, когда идут проверки на разделитель, неправильные операторы и т. д.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.