Hanna Kovalenok #41
Open
Hanna Kovalenok #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhigailo
reviewed
Jun 10, 2019
| import pycalc.difcalc as difcalc | ||
| from numbers import Number | ||
| import importlib.util | ||
| from os import path |
There was a problem hiding this comment.
Порядок объявления импортов описан в PEP8
|
|
||
| class CheckAndChange(): | ||
|
|
||
| def do_all_changes(self, expr, module): |
There was a problem hiding this comment.
Для читаемости можно добавлять аннотации функций/методов
| if not re.search(r'[0-9]+', expr): | ||
| const = re.search(r'[A-ZAa-z]+', expr) | ||
| if not const: | ||
| raise Exception("No Numbers in expression") |
There was a problem hiding this comment.
Создание кастомных эксепшенов тоже улучшает читаемость кода
| "==": lambda a, b: a == b, | ||
| "<": lambda a, b: a < b, | ||
| "!=": lambda a, b: a != b | ||
|
|
There was a problem hiding this comment.
Зачем такое количество пустых строк?
| a = calculator.calculate(args.a) | ||
|
|
||
| else: | ||
| print("!)!))@))@)@)@))@)@)@)@)))))))") |
There was a problem hiding this comment.
Зачем нужен такой принт?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.