-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an OgmiosV6 backend based on ogmios-python #368
Conversation
This requires bumping the python version to 3.10+, because ogmios-python requires this. I also refactored the chain backend to not have built-in kupo support but just provide it as an extension using kupo-wrappers. This way, both OgmiosV5 and OgmiosV6 directly have support for kupo.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 83.97% 81.41% -2.57%
==========================================
Files 29 31 +2
Lines 3732 3954 +222
Branches 940 984 +44
==========================================
+ Hits 3134 3219 +85
- Misses 433 571 +138
+ Partials 165 164 -1 ☔ View full report in Codecov by Sentry. |
This error occurs in mypy, not sure where it comes from
|
Wow nice! Thanks a lot for adding this support. Will take a look at the error. |
Yes unfortunately Ogmios does not support python 3.8 and 3.9 |
I had to bump the python version of mypy to "3.10" for this to run. Here are few errors:
|
fyi, I tried to work with this branch and here's another error I encountered: File ".../pycardano/backend/ogmios_v6.py", line 288, in _utxo_from_ogmios_result I guess in (at least) the following two places the pycardano.Address should be used instead of ogmios.datatypes.Address: pycardano/pycardano/backend/ogmios_v6.py Line 272 in 0e285e5
pycardano/pycardano/backend/ogmios_v6.py Line 288 in 0e285e5
|
When this is ready to merge, I'll release the compatible version of ogmios-python (currently in the |
Thanks @wrmarchetto ! |
Thanks for fixing issues! FYI, I merged this branch ( |
Sounds good. |
This requires bumping the python version to 3.10+, because ogmios-python requires this. I also refactored the chain backend to not have built-in kupo support but just provide it as an extension using kupo-wrappers. This way, both OgmiosV5 and OgmiosV6 directly have support for kupo.