Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot init blockfrost chain context #358

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Conversation

thaopt
Copy link
Contributor

@thaopt thaopt commented Jun 7, 2024

fixed: #353

This one should be str as defined in the function description.
i cannot initialize the blockfrost chain context due to the recent change:

base_url: Optional[str] = None
...
self._base_url = (base_url) ==> base_url
....
if "mainnet" in self._base_url.value:
self._network = Network.MAINNET

self._base_url is str then cannot have attr value (maybe enum item i think) so cannot init the context properly

@thaopt
Copy link
Contributor Author

thaopt commented Jun 7, 2024

I am not sure if have any testcase for this recent change?

@thaopt thaopt changed the title Update blockfrost.py Cannot init blockfrost chain context Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (7fbbe68) to head (f5f9239).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   83.68%   83.98%   +0.29%     
==========================================
  Files          29       29              
  Lines        3733     3733              
  Branches      941      941              
==========================================
+ Hits         3124     3135      +11     
+ Misses        445      433      -12     
- Partials      164      165       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cffls
Copy link
Collaborator

cffls commented Jun 8, 2024

Thanks for fixing this! I will add some tests to it.

@cffls cffls merged commit cc378c2 into Python-Cardano:main Jun 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants