Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle utxoCostPerByte vs coinsPerUtxoByte in cardano-cli chain context protocol params #351

Merged
merged 5 commits into from
Jun 1, 2024

Conversation

KINGH242
Copy link
Contributor

This is the fix for #350

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (20e8ed7) to head (9cfb95f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   83.61%   83.70%   +0.08%     
==========================================
  Files          29       29              
  Lines        3722     3718       -4     
  Branches      939      937       -2     
==========================================
  Hits         3112     3112              
+ Misses        445      443       -2     
+ Partials      165      163       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cffls
Copy link
Collaborator

cffls commented May 26, 2024

Looks like some integration tests failed

>       return (
            constant_overhead + len(tmp_out.to_cbor())
        ) * context.protocol_param.coins_per_utxo_byte
E       TypeError: unsupported operand type(s) for *: 'int' and 'NoneType'

../pycardano/utils.py:183: TypeError

Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cffls cffls merged commit 01edc0d into Python-Cardano:main Jun 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants