Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 Fix None default role in user installed apps. #2650

Merged
merged 3 commits into from
Nov 14, 2024
Merged

fix: 🐛 Fix None default role in user installed apps. #2650

merged 3 commits into from
Nov 14, 2024

Conversation

Paillat-dev
Copy link
Contributor

@Paillat-dev Paillat-dev commented Nov 14, 2024 •
edited
Loading

Summary

fix #2649

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev Paillat-dev requested a review from a team as a code owner November 14, 2024 08:04
@Paillat-dev Paillat-dev changed the title 🐛 Fix None default role in user installed apps. fix: 🐛 Fix None default role in user installed apps. Nov 14, 2024
@plun1331 plun1331 enabled auto-merge (squash) November 14, 2024 14:00
@plun1331 plun1331 requested review from JustaSqu1d and removed request for CodeWithSwastik November 14, 2024 14:00
@plun1331 plun1331 added bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer labels Nov 14, 2024
@plun1331 plun1331 added this to the v2.7 milestone Nov 14, 2024
Lulalaby
Lulalaby approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meow

@plun1331 plun1331 merged commit e4946ec into Pycord-Development:master Nov 14, 2024
25 checks passed
@Paillat-dev Paillat-dev deleted the fix-role-none branch November 14, 2024 19:25
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Dec 16, 2024
@Paillat-dev @pre-commit-ci @OmLanke
fix: 🐛 Fix None default role in user installed apps. (Pycord-Develo…
0d8dca4 
…pment#2650)

* 🐛 Fix `None` default role in user installed apps.

* 📝 CHANGELOG.md

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

Assignees
No one assigned
Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.7
3 participants
@Paillat-dev @Lulalaby @plun1331