Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: message forwarding #2598

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

feat: message forwarding #2598

wants to merge 17 commits into from

Conversation

NeloBlivion
Copy link
Member

Summary

Implements message forwarding, alongside some small cleanups for other message features.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion
Copy link
Member Author

NeloBlivion commented Oct 6, 2024 •
edited
Loading

more or less done, just need to add mention/role mention handling and partialmessage support... but still 403ing on my bot 😔

@Lulalaby
Copy link
Member

Lulalaby commented Oct 6, 2024 •
edited
Loading

unlucky bcs its 95% out. you're in th holdout group. try making a new bot

@JustaSqu1d JustaSqu1d added priority: medium Medium Priority feature Implements a feature API Reflection Discords API wasn't correctly reflected in the lib python Pull requests that update Python code labels Oct 21, 2024
@JustaSqu1d JustaSqu1d added this to the v2.7 milestone Nov 18, 2024
DA-344
DA-344 reviewed Nov 27, 2024
View reviewed changes
discord/message.py

Parameters
----------
channel: Union[:class:`Emoji`, :class:`Reaction`, :class:`PartialEmoji`, :class:`str`]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this Union[Emoji, Reaction, PartialEmoji, str]...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DA-344 DA-344 DA-344 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
API Reflection Discords API wasn't correctly reflected in the lib feature Implements a feature priority: medium Medium Priority python Pull requests that update Python code
Projects
None yet
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@NeloBlivion @Lulalaby @DA-344 @JustaSqu1d