Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app emojis #2501

Merged
merged 36 commits into from
Oct 17, 2024
Merged

feat: app emojis #2501

merged 36 commits into from
Oct 17, 2024

Conversation

NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented Jul 19, 2024

Summary

Implements discord/discord-api-docs#7010
Very rough draft, considering new emoji classes

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lulalaby Lulalaby assigned Lulalaby and NeloBlivion and unassigned Lulalaby Jul 19, 2024
@Lulalaby Lulalaby self-requested a review July 19, 2024 00:42
@Lulalaby Lulalaby added priority: medium Medium Priority status: in progress Work in Progess feature Implements a feature labels Jul 19, 2024
@Lulalaby Lulalaby added this to the v2.7 milestone Jul 19, 2024
@NeloBlivion NeloBlivion marked this pull request as ready for review July 23, 2024 17:56
@NeloBlivion NeloBlivion requested a review from a team as a code owner July 23, 2024 17:56
@NeloBlivion
Copy link
Member Author

Removed draft status as this is completely functional, just have to go through and replace instances of Emoji with GuildEmoji (Emoji is still aliased, possibly deprecate for 2.7?)

plun1331
plun1331 previously approved these changes Oct 4, 2024
@plun1331
Copy link
Member

Merge conflicts

@NeloBlivion NeloBlivion requested a review from plun1331 October 17, 2024 00:34
plun1331
plun1331 previously approved these changes Oct 17, 2024
@plun1331 plun1331 enabled auto-merge (squash) October 17, 2024 15:35
@plun1331
Copy link
Member

conflicts (again)

auto-merge was automatically disabled October 17, 2024 15:39

Head branch was pushed to by a user without write access

@plun1331 plun1331 enabled auto-merge (squash) October 17, 2024 15:41
@plun1331 plun1331 merged commit 72ba1b1 into Pycord-Development:master Oct 17, 2024
25 checks passed
baribarton pushed a commit to baribarton/pycord-no-potential-reconnect that referenced this pull request Oct 24, 2024
* add routes

* unfinished methods, needs rework

* style(pre-commit): auto fixes from pre-commit.com hooks

* new classes

* style(pre-commit): auto fixes from pre-commit.com hooks

* refinements

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix kwargs

* _state -> _connection

* style(pre-commit): auto fixes from pre-commit.com hooks

* cache on ready

* full cache

* remove delete reason

* style(pre-commit): auto fixes from pre-commit.com hooks

* adjust slots

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update discord/emoji.py

Signed-off-by: plun1331 <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

* update all references to the Emoji class

* style(pre-commit): auto fixes from pre-commit.com hooks

* misc

* cl

* style(pre-commit): auto fixes from pre-commit.com hooks

* add deprecation

---------

Signed-off-by: plun1331 <[email protected]>
Signed-off-by: UK <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lala Sabathil <[email protected]>
Co-authored-by: plun1331 <[email protected]>
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Dec 16, 2024
* add routes

* unfinished methods, needs rework

* style(pre-commit): auto fixes from pre-commit.com hooks

* new classes

* style(pre-commit): auto fixes from pre-commit.com hooks

* refinements

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix kwargs

* _state -> _connection

* style(pre-commit): auto fixes from pre-commit.com hooks

* cache on ready

* full cache

* remove delete reason

* style(pre-commit): auto fixes from pre-commit.com hooks

* adjust slots

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update discord/emoji.py

Signed-off-by: plun1331 <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

* update all references to the Emoji class

* style(pre-commit): auto fixes from pre-commit.com hooks

* misc

* cl

* style(pre-commit): auto fixes from pre-commit.com hooks

* add deprecation

---------

Signed-off-by: plun1331 <[email protected]>
Signed-off-by: UK <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lala Sabathil <[email protected]>
Co-authored-by: plun1331 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature priority: medium Medium Priority status: in progress Work in Progess
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants