Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Duplication in bridge command help #2414

Closed
wants to merge 2 commits into from
Closed

fix: Duplication in bridge command help #2414

wants to merge 2 commits into from

Conversation

Blue-Robin-Taken
Copy link
Contributor

@Blue-Robin-Taken Blue-Robin-Taken commented Apr 3, 2024

Summary

This pull request is for the issue #2306

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Blue-Robin-Taken Blue-Robin-Taken requested a review from a team as a code owner April 3, 2024 11:26
@pullapprove4 pullapprove4 bot requested a review from ChickenDevs April 3, 2024 11:26
@pullapprove4 pullapprove4 bot requested a review from WhoIsConch April 3, 2024 11:26
@Blue-Robin-Taken Blue-Robin-Taken marked this pull request as draft April 3, 2024 11:26
@Blue-Robin-Taken Blue-Robin-Taken changed the title Update help.py fix: Duplication in bridge command help Apr 3, 2024
@Blue-Robin-Taken
Copy link
Contributor Author

Just need to add docs and changelog

@Blue-Robin-Taken Blue-Robin-Taken marked this pull request as ready for review April 3, 2024 11:39
@Dorukyum Dorukyum requested review from Dorukyum and removed request for ChickenDevs and WhoIsConch April 3, 2024 20:27
@Lulalaby Lulalaby enabled auto-merge (squash) April 3, 2024 23:22
@solaluset
Copy link
Contributor

This breaks the command if ext.bridge is not imported:

Ignoring exception in command help:
Traceback (most recent call last):
  File "/data/data/com.termux/files/home/tests/lib/python3.11/site-packages/discord/ext/commands/core.py", line 180, in wrapped
    ret = await coro(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/data/com.termux/files/home/tests/lib/python3.11/site-packages/discord/ext/commands/help.py", line 858, in command_callback
    return await self.send_bot_help(mapping)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/data/com.termux/files/home/tests/lib/python3.11/site-packages/discord/ext/commands/help.py", line 1074, in send_bot_help
    self.add_indented_commands(commands, heading=category, max_size=max_size)
  File "/data/data/com.termux/files/home/tests/lib/python3.11/site-packages/discord/ext/commands/help.py", line 1000, in add_indented_commands
    command, discord.ext.bridge.core.BridgeExtCommand
             ^^^^^^^^^^^^^^^^^^
AttributeError: module 'discord.ext' has no attribute 'bridge'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/data/data/com.termux/files/home/tests/lib/python3.11/site-packages/discord/ext/commands/bot.py", line 349, in invoke
    await ctx.command.invoke(ctx)
  File "/data/data/com.termux/files/home/tests/lib/python3.11/site-packages/discord/ext/commands/core.py", line 959, in invoke
    await injected(*ctx.args, **ctx.kwargs)
  File "/data/data/com.termux/files/home/tests/lib/python3.11/site-packages/discord/ext/commands/core.py", line 189, in wrapped
    raise CommandInvokeError(exc) from exc
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: module 'discord.ext' has no attribute 'bridge'

auto-merge was automatically disabled April 5, 2024 12:45

Head branch was pushed to by a user without write access

auto-merge was automatically disabled April 5, 2024 12:45

Pull request was closed

@Blue-Robin-Taken
Copy link
Contributor Author

oh frick

@Blue-Robin-Taken
Copy link
Contributor Author

that uh

@Blue-Robin-Taken
Copy link
Contributor Author

Ok Ima fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants