-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement (Sync)WebhookMessage.thread
#2314
Conversation
Signed-off-by: CommandLine <[email protected]>
Signed-off-by: CommandLine <[email protected]>
Signed-off-by: CommandLine <[email protected]>
WebhookMessage.edit
and WebhookMessage.delete
assuming that their _thread_id
can not be None
WebhookMessage.edit
and WebhookMessage.delete
assuming that their _thread_id
can not be None
WebhookMessage.edit
and WebhookMessage.delete
assuming that their _thread_id
can not be None
Object
created with None
id
Your changes might fix the issue but I think the best way to approach this is to create a property called |
I agree with doru |
Signed-off-by: CommandLine <[email protected]>
Head branch was pushed to by a user without write access
Signed-off-by: CommandLine <[email protected]>
Wait, i read comment wrong... |
Signed-off-by: CommandLine <[email protected]>
Signed-off-by: CommandLine <[email protected]>
so, something like that? never worked on big projects (and typing to be honest), so my style may be weird |
Signed-off-by: CommandLine <[email protected]>
Signed-off-by: CommandLine <[email protected]>
Signed-off-by: CommandLine <[email protected]>
all i see here is an |
Signed-off-by: Dorukyum <[email protected]>
I went ahead and replaced your solution with adding Requires testing. |
Object
created with None
id(Sync)WebhookMessage.thread
After looking with a clear mind into the issue I realized none of these changes were necessary. Will open a new pr with just 2 lines changed. Thanks nevertheless. |
Summary
Related to issue #2298
Fixes webhook messages assuming that their
_thread_id
can not beNone
(spoiler; it can)Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.