fix: AttributeError when comparing commands

[Dorukyum]

Summary

Fixes AttributeErrors that occur when comparing application commands with non-command objects.

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.

[Lulalaby]

mhh i would be careful with such a check.
a simple dict eq check won't do i fear and might cause ratelimit hits.

[Dorukyum]

@Lulalaby I don't quite understand why this won't do, what's the issue and what do you suggest?

[Lulalaby]

discord tends to mess up the received orders of properties and send back complete different ones.
I'm not sure how pythons methods work but for c# it caused many problems.
I feel like this wouldn't make it precise.. instead more unprecise
I might be wrong

[Dorukyum]

I might've overlooked stuff like that, will look into our sync algorithm again to see if this could cause any issues.

[plun1331]

discord tends to mess up the received orders of properties and send back complete different ones. I'm not sure how pythons methods work but for c# it caused many problems. I feel like this wouldn't make it precise.. instead more unprecise I might be wrong

if you're referring to the order in which the data is sent back, i believe dictionaries are unordered by default

[Dorukyum]

Yes, that's right, but I figured I'd still check everything in case some info is missing somewhere or whatever ({"a": 1} is not equal to {"a": 1, "b": 2}). Will update today.

[Dorukyum]

I think the only thing this will break is Bot.add_application_command as it loops through pending application commands to update their IDs. I suggest we update that method before merging this PR to fix the AttributeErrors, but eventually refactor the way commands are stored.

[Lulalaby]

good that i reminded you to check

[Dorukyum]

Now that I think about it, it actually comes down to what we want this method to check: either the commands having the same frontend (the same name in the same guilds) or the commands being completely identical. I reworked this pull request to only fix the potential AttributeErrors, while keeping the original functionality of the method.