Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext.commands): required is False although default is None #2282

Merged
merged 3 commits into from
Dec 14, 2023
Merged

fix(ext.commands): required is False although default is None #2282

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64d1c04
fix(ext.commands): Fixed required=False when default is None
solaluset Dec 9, 2023
63b67e2
fix(ext.commands): Ignore default when checking if arg is required
solaluset Dec 11, 2023
ad18b8d
Merge branch 'master' into bridge-default-fix
plun1331 Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion discord/ext/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ async def dispatch_error(self, ctx: Context, error: Exception) -> None:
async def transform(self, ctx: Context, param: inspect.Parameter) -> Any:
if isinstance(param.annotation, Option):
default = param.annotation.default
required = param.annotation.required or default is None
required = param.annotation.required
else:
default = param.default
required = default is param.empty
Expand Down
Loading