Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow users to run one command to install both packages for speedup and voice support #2261

Closed
wants to merge 5 commits into from

Conversation

catdogmat
Copy link

Summary

This PR allows users to run one command to install both packages for speedup and voice support, eg:
python3 -m pip install py-cord[all]

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters). (kinda, it adds a new install method)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...). (kinda, it updates docs and pyproject)

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@catdogmat
Copy link
Author

Closing as I think I broke something

Signed-off-by: Finn <[email protected]>
@catdogmat
Copy link
Author

Ok fixed

@catdogmat
Copy link
Author

Fixing title

@catdogmat catdogmat closed this Nov 13, 2023
@catdogmat catdogmat changed the title Allow users to run one command to install both packages for speedup and voice support feat: Allow users to run one command to install both packages for speedup and voice support Nov 13, 2023
@catdogmat catdogmat reopened this Nov 13, 2023
@catdogmat
Copy link
Author

Sorry if this is bad, I'm new to big repos

@Lulalaby
Copy link
Member

Thanks for your contribution. In my opinion this isn't really needed tho.
We'll discuss that.

@Lulalaby
Copy link
Member

We're not gonna accept this PR at this point.
Thank you tho

@Lulalaby Lulalaby closed this Nov 13, 2023
@VincentRPS
Copy link
Member

Is pycord[speed,voice]=a.b.c just too much? I don't think there is any worth in adding a shortcut to what is already so simple. Maybe in the future, if we get more extra dependencies, but at the moment, two is not enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants