Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext.bridge/commands): default arguments with Option don't work #2256

Merged
merged 5 commits into from
Nov 29, 2023
Merged

fix(ext.bridge/commands): default arguments with Option don't work #2256

merged 5 commits into from
Nov 29, 2023

Conversation

Middledot
Copy link
Member

Summary

Fix #2089
Bridge commands that use discord.Option don't have their default values or "required" attributes recognized by ext.commands.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Middledot Middledot requested a review from a team as a code owner November 6, 2023 03:00
@Middledot Middledot mentioned this pull request Nov 6, 2023
Closed
3 tasks
Dorukyum
Dorukyum requested changes Nov 26, 2023
View reviewed changes
discord/ext/commands/core.py Outdated Show resolved Hide resolved
@Middledot @Dorukyum
Apple code suggestion
dfb2bf1 
Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: Middledot <[email protected]>
Dorukyum
Dorukyum previously approved these changes Nov 29, 2023
View reviewed changes
@Dorukyum Dorukyum enabled auto-merge (squash) November 29, 2023 17:32
@Dorukyum Dorukyum merged commit a7f4adb into master Nov 29, 2023
45 checks passed
@Dorukyum Dorukyum deleted the fix-2089 branch January 21, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent default arguments in bridge commands
2 participants
@Middledot @Dorukyum