-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added difference between get_ commands and fetch_ commands in FAQ #2123
docs: added difference between get_ commands and fetch_ commands in FAQ #2123
Conversation
Added the difference between get_ commands and fetch_ commands Signed-off-by: Blue-Robin-Taken <[email protected]>
Signed-off-by: Blue-Robin-Taken <[email protected]>
Signed-off-by: Blue-Robin-Taken <[email protected]>
Signed-off-by: Blue-Robin-Taken <[email protected]>
Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: Blue-Robin-Taken <[email protected]>
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using a simpler example like bot.fetch_user vs bot.get_user would be easier to understand.
My previous review still applies.
I think this change leads to nowhere. |
Saying that you need |
Then please create a solid pull request yourself with a correct faq about it or better document it in the docstring |
@Lulalaby What exactly do you want?
What would be a "solid" PR, and can't I edit and fix the PR here? |
"user stupidness" wasn't meant as in your pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using a simpler example like bot.fetch_user vs bot.get_user would be easier to understand.
My previous review still applies.
You can't just re-request a review without acknowledging my previous one.
my thoughts on this: i personally haven't seen this question frequently asked |
Yeah exactly that and that's why I've closed it in the first place. But squid reopened it |
I thought I did but I don't have much github experience... Sorry about that. I'll try to fix it |
Although it's not frequently asked, it's gotta be listed somewhere when it is asked. |
Separated the example into two examples Signed-off-by: Blue-Robin-Taken <[email protected]>
simple: no where |
Signed-off-by: Blue-Robin-Taken <[email protected]>
In the entire time I've been with pycord I've only observed it asked 3-5 times, and the answer is fairly simple to explain each time: get_x gets from cache, fetch_x fetches from discord If we had to make an entry for every question asked about the library, this FAQ page would be extremely long |
And so I'm closing it. |
Added the difference between get_ commands and fetch_ commands
Summary
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.