Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add slowmode_delay attribute to discord.VoiceChannel #2112

Merged
merged 13 commits into from
Nov 29, 2023

Conversation

its-darsh
Copy link
Contributor

Summary

This PR added a new attribute for the discord.VoiceChannel which's slowmode_delay while it was missing, doc-strings has been updated.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made, then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

adds the `slowmode_delay` attribute to the `discord.VoiceChannel` class.

Signed-off-by: DARSH <[email protected]>
Signed-off-by: DARSH <[email protected]>
@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #2112 (409ed55) into master (763b14a) will decrease coverage by 0.01%.
Report is 50 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
- Coverage   33.13%   33.13%   -0.01%     
==========================================
  Files          97       97              
  Lines       19141    19142       +1     
==========================================
  Hits         6342     6342              
- Misses      12799    12800       +1     
Flag Coverage Δ
macos-latest-3.10 33.11% <0.00%> (-0.01%) ⬇️
macos-latest-3.11 33.11% <0.00%> (-0.01%) ⬇️
macos-latest-3.8 33.12% <0.00%> (-0.01%) ⬇️
macos-latest-3.9 33.12% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.11% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.11% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.12% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.12% <0.00%> (-0.01%) ⬇️
windows-latest-3.10 33.11% <0.00%> (-0.01%) ⬇️
windows-latest-3.11 33.11% <0.00%> (-0.01%) ⬇️
windows-latest-3.8 33.12% <0.00%> (-0.01%) ⬇️
windows-latest-3.9 33.12% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
discord/channel.py 34.06% <0.00%> (-0.05%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763b14a...409ed55. Read the comment docs.

@its-darsh its-darsh changed the title Attribute slowmode_delay for VoiceChannel feat: Add slowmode_delay attribute to discord.VoiceChannel Jun 11, 2023
discord/channel.py Outdated Show resolved Hide resolved
discord/channel.py Show resolved Hide resolved
discord/channel.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@plun1331 plun1331 added priority: low Low Priority status: in progress Work in Progess feature Implements a feature API Reflection Discords API wasn't correctly reflected in the lib labels Jun 13, 2023
@plun1331 plun1331 added this to the v2.5 milestone Jun 13, 2023
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing version added?

@its-darsh
Copy link
Contributor Author

it's been so long, if someone needed me please mention.

discord/channel.py Show resolved Hide resolved
discord/channel.py Show resolved Hide resolved
its-darsh and others added 2 commits September 26, 2023 07:19
Co-authored-by: plun1331 <[email protected]>
Signed-off-by: The Darsh <[email protected]>
Signed-off-by: The Darsh <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: The Darsh <[email protected]>
@Lulalaby Lulalaby requested a review from Dorukyum November 27, 2023 14:49
@Lulalaby Lulalaby merged commit 257d61a into Pycord-Development:master Nov 29, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib feature Implements a feature on hold priority: low Low Priority status: in progress Work in Progess
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants