refactor: rename and fix pop_temp_bucket

Pycord-Development · Jan 7, 2024 · fe0e6f0 · fe0e6f0
1 parent 6331678
commit fe0e6f0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/discord/http.py b/discord/http.py
@@ -337,7 +337,7 @@ async def request(
                                     await tbucket.use(
                                         retry_after, remaining or 10, is_global=True
                                     )
-                                    await self._rate_limit.pop_temp_bucket(bucket_id)
+                                    await self._rate_limit.delete_temp_bucket(bucket_id)
 
                                 _log.debug(
                                     "Done sleeping for the rate limit. Retrying..."

diff --git a/discord/rate_limiting.py b/discord/rate_limiting.py
@@ -387,7 +387,7 @@ async def push_temp_bucket(self, id: str, bucket: DynamicBucket) -> None:
             This bucket's identifier.
         """
 
-    async def pop_temp_bucket(self, id: str) -> None:
+    async def delete_temp_bucket(self, id: str) -> None:
         """Pop a temporary bucket which *may* be in storage.
 
         Parameters
@@ -499,16 +499,17 @@ async def push_temp_bucket(self, id: str, bucket: DynamicBucket) -> None:
 
         self._temp_buckets[id] = bucket
 
-    async def pop_temp_bucket(self, id: str) -> None:
-        """Pop a temporary bucket which *may* be in storage.
+    async def delete_temp_bucket(self, id: str) -> None:
+        """Delete a temporary bucket which may be in storage.
 
         Parameters
         ----------
         id: :class:`str`
             This bucket's identifier.
         """
 
-        del self._temp_buckets[id]
+        if id in self._temp_buckets:
+            del self._temp_buckets[id]
 
 
 class DynamicBucket: