Skip to content

Commit

Permalink
fix: change default attribute of SlashCommandGroup (#2303)
Browse files Browse the repository at this point in the history
* Update core.py and changelog

* Update core.py

* Update core.py

* Update core.py

* chore: update changelog

* fix: remove all references to cog being MISSING

---------

Signed-off-by: Dasupergrasskakjd <[email protected]>
Co-authored-by: Dorukyum <[email protected]>
  • Loading branch information
Dasupergrasskakjd and Dorukyum authored Jan 3, 2024
1 parent 8af8454 commit fc7b104
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#2295](https://github.com/Pycord-Development/pycord/issues/2295))
- Fixed `AttributeError` when failing to establish initial websocket connection.
([#2301](https://github.com/Pycord-Development/pycord/pull/2301))
- Fixed `AttributeError` caused by `command.cog` being `MISSING`.
([#2303](https://github.com/Pycord-Development/pycord/issues/2303))

## [2.4.1] - 2023-03-20

Expand Down
9 changes: 3 additions & 6 deletions discord/commands/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,7 @@ def _is_typing_annotated(self, annotation):

@property
def cog(self):
return getattr(self, "_cog", MISSING)
return getattr(self, "_cog", None)

@cog.setter
def cog(self, val):
Expand Down Expand Up @@ -1162,7 +1162,7 @@ def __init__(

self._before_invoke = None
self._after_invoke = None
self.cog = MISSING
self.cog = None
self.id = None

# Permissions
Expand Down Expand Up @@ -1238,10 +1238,7 @@ def to_dict(self) -> dict:
return as_dict

def add_command(self, command: SlashCommand) -> None:
# check if subcommand has no cog set
# also check if cog is MISSING because it
# might not have been set by the cog yet
if command.cog is MISSING and self.cog is not MISSING:
if command.cog is None and self.cog is not None:
command.cog = self.cog

self.subcommands.append(command)
Expand Down

0 comments on commit fc7b104

Please sign in to comment.