Update draco to fix build error #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guide Update CONTRIBUTING.md
Closes #466
Restore IE support.
* Added option to build Draco for Universal Scene Description * Code cleanup * Bug fixes
Update gems to address reported vulnerabilities.
Hopefully also kicks off a gh-pages rebuild.
Update page footer template to display current year in copyright legend.
TravisCI: Use newer linux images.
- Move common NDK settings into cmake/toolchains/android-ndk-common.cmake. - Fix bug in set_variable_if_unset(). Was ignoring variables set via CMake's command line. Fixes #475.
draco: Mostly CMake updates.
Change the name to avoid conflict with Windows headers.
draco cmake: make unity plugin decoder a static lib on ios.
Rename Status::ERROR to Status::DRACO_ERROR.
We rely upon CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS for windows DLL support, but we must defer the BUILD_SHARED_LIBS check until after the plugin args are checked since the plugin checks can enable BUILD_SHARED_LIBS. Without this change Visual Studio will not create import libs for the draco DLLs, and that breaks the build.
draco cmake: Defer windows shared lib check until after plugin checks.
ELIMINATE_DUPLICATE_FUNCTIONS=1 is no longer required: it is now a default.
Fix some javascript issues.
Avoid a confusing failure mode for javascript builds by requiring that points at an existing directory. Prevents failure of custom commands late in the configure and build processes.
There is no need to perform the check if T is of type bool, since it is guaranteed to fit in all other integral types. This avoids triggering a C4804 warning in Visual Studio, ie. `unsafe use of type 'bool' in operation`
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.1 to 1.13.3. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.13.1...v1.13.3) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This enabled CI testing of transcoder configs and includes a few minor Windows-only bug fixes. Note that this adds flags to skip GltfDecoderTest.ThreeMeshesOneNoMaterialMesh for Windows MSVC CI builds. See #826 for details. Windows specific updates (these do impact non-Windows builds, but are essentially a no-op there): - Use a local dupe of a constant to avoid DLL linkage issues on Windows in the GLTF encoder test.. - Define DRACO_PI to avoid M_PI and entertaining include ordering issues related to _USE_MATH_DEFINES and interactions between <cmath> and <math.h> on Windows (fun include guards and order related things). This is done in core/constants.h.
Not really sure who is to blame, but in optimized builds from MSVC gltf_decoder.cc appears to be getting garbage values back from TinyGLTF when it parses the materials for testdata/.../three_meshes_two_materials_one_no_material.gltf Since there's no certainty about whether this is limited to this particular file, just disable optimizations for src/draco/io/gltf_decoder.cc in all MSVC build configurations.
Includes support for binary STL and some basic tests.
- Fix version file name. - Fix install path for config and version file. - Updates the install test to correctly set prefix and allow CMake's built-in search functionality to work properly.
Fix windows DLL install location and update the install test with the following - Use cxx_std_11 compile feature instead of forcing CXX_STANDARD to C++11. - Move install test prefix handling to test.py (was in the install test CMakeLists.txt). - Use CMAKE_INSTALL_RPATH and add dylib location to PATH instead of copying it only on Windows-- makes test more generic and makes install_test much simpler.
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.3 to 1.13.4. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/v1.13.4/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.13.3...v1.13.4) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This a refactoring of the CMake config file to follow best practices: - A draco-targets.cmake is generated with install(EXPORT ...), and included in draco-config.cmake. - For users consuming Draco with add_subdirectory(), a draco::draco alias is provided. - Removed find-draco.cmake-- CMake couldn't use it anyway due to the file name not matching CMake expectations for a find script. Note: this also removes the previous methods of hardcoding the C++ standard in the Draco build to C++11. Instead of direct manipulation of CMAKE_CXX_STANDARD target_compile_features() is used. External projects consuming Draco should now be able to set the standard to a newer version.
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.4 to 1.13.6. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.13.4...v1.13.6) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
/compression/attributes/attributes_decoder_interface.h was omitted, which broke Bazel builds. Fixes: #912
Bumps [tzinfo](https://github.com/tzinfo/tzinfo) from 1.2.5 to 1.2.10. - [Release notes](https://github.com/tzinfo/tzinfo/releases) - [Changelog](https://github.com/tzinfo/tzinfo/blob/master/CHANGES.md) - [Commits](tzinfo/tzinfo@v1.2.5...v1.2.10) --- updated-dependencies: - dependency-name: tzinfo dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Use ubuntu-22 and clang-14 for the clang CI test. * Use default gcc on ubuntu-latest builders. * Windows configs skip GltfDecoderTest.TestLoadUnsupportedTexCoordAttributes, see #938
Fixed warning regarding comparing a signed variable `bit` with unsigned `nbits`. The value `nbits` is checked to be less then or equal to 32 in the rows above, which prevents overflow when casting to a signed type.
This was causing failure to compile on GCC 13.
after it was removed a few years ago in the update to 1.4.0
Co-authored-by: Ondrej Stava <[email protected]>
This reverts commit 295ea7c.
* Draco v1.5.6 release.
* Draco 1.5.7 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyMesh currently fails build due to issue fixed at google@d9006bf